r74898 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r74897‎ \| r74898 \| r74899 >
Date:	15:12, 17 October 2010
Author:	hartman
Status:	ok
Tags:
Comment:	Use getAttribute( 'href', 2), so we can preserve relative paths if we want. Fixes bug 25549
Modified paths:	/trunk/phase3/skins/common/search.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/search.js
—	—	@@ -11,7 +11,7 @@
12	12	}
13	13
14	14	var searchterm = searchbox.value;
15		~~- var parts = obj.href.split( 'search=' );~~
	15	+ var parts = obj.getAttribute( 'href', 2).split( 'search=' );
16	16	var lastpart = '';
17	17	var prefix = 'search=';
18	18	if( parts.length > 1 && parts[1].indexOf('&') >= 0 ) {

01:04, 13 January 2011 Trevor Parscal (WMF) (talk | contribs) changed the tags for r74898 [removed: trevor]
00:01, 13 January 2011 Trevor Parscal (WMF) (talk | contribs) changed the status of r74898 [removed: new added: ok]
00:44, 12 January 2011 MarkAHershberger (talk | contribs) changed the tags for r74898 [added: trevor]