r74897 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74896‎ | r74897 | r74898 >
Date:14:19, 17 October 2010
Author:maxsem
Status:ok
Tags:
Comment:
Merciless war on trailing ?>
Modified paths:
  • /trunk/extensions/DataTransclusion/tests/DataTransclusionTest.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_AutoCompleteCache.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_Component.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_EditPageAjax.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_Navigator.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_Overlay.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_PageHistoryAjax.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_SequencePlayer.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_SequenceTools.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_StreamMeta.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_Tools.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_VideoPlayer.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/articlepages/MV_CategoryPage.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/articlepages/MV_DataPage.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/articlepages/MV_SequencePage.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/specials/MV_SpecialCRUDStream.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/specials/MV_SpecialExport.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/specials/MV_SpecialListStreams.php (modified) (history)
  • /trunk/extensions/MetavidWiki/maintenance/download_from_archive_org.php (modified) (history)
  • /trunk/extensions/MetavidWiki/maintenance/mv_oneTime_fixes.php (modified) (history)
  • /trunk/extensions/MetavidWiki/maintenance/simple_cron.php (modified) (history)
  • /trunk/extensions/MetavidWiki/maintenance/transcode_to_flv.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/HTMLTranslator.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/LanguageGridAccessObject.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/MetaTranslator.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/MultilangLqt.i18n.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/MultilangLqtHooks.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/MultilangThreadController.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/SourceView.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/ThreadLanguage.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/TranslatedBody.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/TranslatedSubject.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/TranslatedThread.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/ApiPlayTracking/ApiPlayTracking.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscode.php (modified) (history)
  • /trunk/extensions/WebDAV/deltav.php (modified) (history)
  • /trunk/extensions/WikiAtHome/NonFreeVideoHandler.php (modified) (history)
  • /trunk/extensions/WikiAtHome/SpecialWikiAtHome.php (modified) (history)
  • /trunk/extensions/WikiAtHome/internalCmdLineEncoder.php (modified) (history)
  • /trunk/extensions/WikiTrust/includes/LocalMode.php (modified) (history)
  • /trunk/extensions/WikiTrust/includes/RemoteMode.php (modified) (history)
  • /trunk/extensions/WikiTrust/includes/TrustUpdateScripts.inc (modified) (history)
  • /trunk/extensions/WikiTrust/includes/WikiTrust.i18n.php (modified) (history)
  • /trunk/extensions/WikiTrust/includes/WikiTrustBase.php (modified) (history)
  • /trunk/extensions/WikiTrust/includes/WikiTrustUpdate.php (modified) (history)
  • /trunk/extensions/WikiTrust/includes/WmfMode.php (modified) (history)
  • /trunk/extensions/WikiTrust/sql/create_db.php (modified) (history)
  • /trunk/extensions/skins/Daddio/Daddio.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiAtHome/NonFreeVideoHandler.php
@@ -330,4 +330,3 @@
331331
332332 }
333333 }
334 -?>
Index: trunk/extensions/WikiAtHome/SpecialWikiAtHome.php
@@ -28,5 +28,3 @@
2929 $wgOut->addHTML( $html );
3030 }
3131 }
32 -
33 -?>
\ No newline at end of file
Index: trunk/extensions/WikiAtHome/internalCmdLineEncoder.php
@@ -79,5 +79,3 @@
8080 print "job not complete? (might be mixing chunkDuration types?) ";
8181 }
8282 }
83 -
84 -?>
\ No newline at end of file
Index: trunk/extensions/MultilingualLiquidThreads/MultilangThreadController.php
@@ -59,4 +59,3 @@
6060 return $parserOutput->getText();
6161 }
6262 }
63 -?>
Index: trunk/extensions/MultilingualLiquidThreads/TranslatedThread.php
@@ -137,4 +137,3 @@
138138 return $this->ttLang;
139139 }
140140 }
141 -?>
\ No newline at end of file
Index: trunk/extensions/MultilingualLiquidThreads/MultilangLqt.i18n.php
@@ -355,5 +355,3 @@
356356 $messages['vi']['multilang_lqt_language_name_ru'] = "Tiếng Nga";
357357 $messages['vi']['multilang_lqt_language_name_th'] = "Thái Lan";
358358 $messages['vi']['multilang_lqt_language_name_vi'] = "Việt";
359 -
360 - ?>
Index: trunk/extensions/MultilingualLiquidThreads/SourceView.php
@@ -50,4 +50,3 @@
5151 }
5252
5353 }
54 -?>
Index: trunk/extensions/MultilingualLiquidThreads/ThreadLanguage.php
@@ -83,4 +83,3 @@
8484 return $this->language;
8585 }
8686 }
87 -?>
\ No newline at end of file
Index: trunk/extensions/MultilingualLiquidThreads/HTMLTranslator.php
@@ -41,6 +41,3 @@
4242 }
4343 }
4444 }
45 -
46 -?>
47 -
\ No newline at end of file
Index: trunk/extensions/MultilingualLiquidThreads/TranslatedBody.php
@@ -95,4 +95,3 @@
9696 return $this->targetLang;
9797 }
9898 }
99 -?>
\ No newline at end of file
Index: trunk/extensions/MultilingualLiquidThreads/MetaTranslator.php
@@ -336,6 +336,3 @@
337337 return $this->sourceLang;
338338 }
339339 }
340 -
341 -?>
342 -
\ No newline at end of file
Index: trunk/extensions/MultilingualLiquidThreads/MultilangLqtHooks.php
@@ -182,4 +182,3 @@
183183 }
184184
185185 }
186 -?>
Index: trunk/extensions/MultilingualLiquidThreads/TranslatedSubject.php
@@ -95,4 +95,3 @@
9696 return $this->targetLang;
9797 }
9898 }
99 -?>
\ No newline at end of file
Index: trunk/extensions/MultilingualLiquidThreads/LanguageGridAccessObject.php
@@ -271,4 +271,3 @@
272272 }
273273 }
274274 }
275 -?>
\ No newline at end of file
Index: trunk/extensions/MetavidWiki/maintenance/simple_cron.php
@@ -19,4 +19,3 @@
2020 $i++;
2121 sleep(1);
2222 }
23 -?>
\ No newline at end of file
Index: trunk/extensions/MetavidWiki/maintenance/transcode_to_flv.php
@@ -204,4 +204,3 @@
205205 }
206206 return round($size,2)." ".$a[$pos];
207207 }
208 -?>
\ No newline at end of file
Index: trunk/extensions/MetavidWiki/maintenance/mv_oneTime_fixes.php
@@ -214,4 +214,3 @@
215215 $inx++;
216216 }
217217 }
218 -?>
\ No newline at end of file
Index: trunk/extensions/MetavidWiki/maintenance/download_from_archive_org.php
@@ -235,4 +235,3 @@
236236 }
237237 return round( $size, 2 ) . " " . $a[$pos];
238238 }
239 -?>
\ No newline at end of file
Index: trunk/extensions/MetavidWiki/includes/specials/MV_SpecialExport.php
@@ -749,4 +749,3 @@
750750 <?php
751751 }
752752 }
753 -?>
Index: trunk/extensions/MetavidWiki/includes/specials/MV_SpecialCRUDStream.php
@@ -231,4 +231,3 @@
232232 }
233233
234234 }
235 -?>
Index: trunk/extensions/MetavidWiki/includes/specials/MV_SpecialListStreams.php
@@ -98,5 +98,3 @@
9999 return $rlink;
100100 }
101101 }
102 -
103 -?>
Index: trunk/extensions/MetavidWiki/includes/articlepages/MV_SequencePage.php
@@ -760,4 +760,3 @@
761761 return '';
762762 }
763763 }
764 -?>
Index: trunk/extensions/MetavidWiki/includes/articlepages/MV_DataPage.php
@@ -143,7 +143,3 @@
144144 return $html . parent::getPreviewText();
145145 }
146146 }
147 -
148 -
149 -
150 -?>
Index: trunk/extensions/MetavidWiki/includes/articlepages/MV_CategoryPage.php
@@ -137,4 +137,3 @@
138138 }
139139 }
140140
141 -?>
Index: trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_SequenceTools.php
@@ -222,4 +222,3 @@
223223 }
224224 }
225225 }
226 -?>
Index: trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_Navigator.php
@@ -88,4 +88,3 @@
8989 $wgOut->addHTML( '</div>' );
9090 }
9191 }
92 -?>
\ No newline at end of file
Index: trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_Tools.php
@@ -259,4 +259,3 @@
260260 return '';
261261 }
262262 }
263 -?>
Index: trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_Overlay.php
@@ -1062,4 +1062,3 @@
10631063 // replace the semantic tag with an empty string:
10641064 return '';
10651065 }
1066 -?>
Index: trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_Component.php
@@ -117,4 +117,3 @@
118118 $wgOut->addHTML( "</fieldset>\n" );
119119 }
120120 }
121 -?>
Index: trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_PageHistoryAjax.php
@@ -12,4 +12,3 @@
1313 if ( !defined( 'MEDIAWIKI' ) ) die( 1 );
1414 class MV_PageHistoryAjax extends PageHistory {
1515 }
16 -?>
Index: trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_StreamMeta.php
@@ -19,4 +19,3 @@
2020 $wgOut->addHTML( '</div>' );
2121 }
2222 }
23 -?>
Index: trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_VideoPlayer.php
@@ -113,4 +113,3 @@
114114 }
115115
116116 }
117 -?>
Index: trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_SequencePlayer.php
@@ -40,4 +40,3 @@
4141 return $export_url;
4242 }
4343 }
44 -?>
Index: trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_EditPageAjax.php
@@ -912,4 +912,3 @@
913913 // $wgOut->addHTML( '</div>' );
914914 }
915915 }
916 -?>
Index: trunk/extensions/MetavidWiki/includes/MV_AutoCompleteCache.php
@@ -12,4 +12,3 @@
1313 class MV_AutoCompleteCache {
1414
1515 }
16 -?>
Index: trunk/extensions/skins/Daddio/Daddio.class.php
@@ -194,4 +194,3 @@
195195 } // end of execute() method
196196 } // end of class
197197
198 -?>
\ No newline at end of file
Index: trunk/extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscode.php
@@ -216,6 +216,3 @@
217217 }
218218 }
219219
220 -
221 -
222 -?>
\ No newline at end of file
Index: trunk/extensions/TimedMediaHandler/ApiPlayTracking/ApiPlayTracking.php
@@ -89,5 +89,3 @@
9090 return __CLASS__ . ': $Id: ApiPlayTracking.php 59374 2009-11-24 01:06:56Z dale $';
9191 }
9292 }
93 -
94 -?>
\ No newline at end of file
Index: trunk/extensions/WebDAV/deltav.php
@@ -59,4 +59,3 @@
6060
6161 $mediaWiki->restInPeace( $wgLoadBalancer );
6262 */
63 -?>
Index: trunk/extensions/DataTransclusion/tests/DataTransclusionTest.php
@@ -507,4 +507,3 @@
508508 $t->runTest();
509509
510510 echo "OK.\n";
511 -?>
Index: trunk/extensions/WikiTrust/sql/create_db.php
@@ -145,5 +145,3 @@
146146 $db_root->query("COMMIT");
147147
148148 print ($do_remove)? "Removed tables\n": "Created tables\n";
149 -
150 -?>
Index: trunk/extensions/WikiTrust/includes/WikiTrustUpdate.php
@@ -29,5 +29,3 @@
3030 return true;
3131 }
3232 }
33 -
34 -?>
Index: trunk/extensions/WikiTrust/includes/TrustUpdateScripts.inc
@@ -122,4 +122,3 @@
123123
124124 $remove_index_scripts[$wgDBprefix . "revision"]['wt_revision_id_timestamp_idx'] = "DROP INDEX wt_revision_id_timestamp_idx ON ".$wgDBprefix."revision";
125125
126 -?>
Index: trunk/extensions/WikiTrust/includes/WmfMode.php
@@ -189,5 +189,3 @@
190190 return true;
191191 }
192192 }
193 -
194 -?>
Index: trunk/extensions/WikiTrust/includes/LocalMode.php
@@ -3,4 +3,3 @@
44 class WikiTrust extends WikiTrustBase {
55 }
66
7 -?>
Index: trunk/extensions/WikiTrust/includes/RemoteMode.php
@@ -267,5 +267,3 @@
268268 }
269269
270270 }
271 -
272 -?>
Index: trunk/extensions/WikiTrust/includes/WikiTrustBase.php
@@ -844,5 +844,3 @@
845845 FILE_APPEND|LOCK_EX);
846846 }
847847 }
848 -
849 -?>
Index: trunk/extensions/WikiTrust/includes/WikiTrust.i18n.php
@@ -24,4 +24,3 @@
2525 | This page is not part of the trust experement yet.
2626 |}',
2727 );
28 -?>

Status & tagging log