r74749 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r74748‎ | r74749 | r74750 >
Date:23:52, 13 October 2010
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
White space changes
Modified paths:
  • /trunk/phase3/includes/ResourceLoader.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ResourceLoader.php
——@@ -323,10 +323,7 @@
324324
325325 // Styles
326326 $styles = array();
327 - if (
328 - $context->shouldIncludeStyles() &&
329 - ( count( $styles = $module->getStyles( $context ) ) )
330 - ) {
 327+ if ( $context->shouldIncludeStyles() && ( count( $styles = $module->getStyles( $context ) ) ) ) {
331328 // Flip CSS on a per-module basis
332329 if ( $this->modules[$name]->getFlip( $context ) ) {
333330 foreach ( $styles as $media => $style ) {

Comments

#Comment by Nikerabbit (talk | contribs)   06:15, 14 October 2010

The assignment in the if condition makes it hard to guess whether this is correct or not. There is also extra set of parentheses around count.

Status & tagging log