r74727 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r74726‎ | r74727 | r74728 >
Date:19:01, 13 October 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Fixup "} elseif ( $cond[0] = '!' ) {" from r35983


NB, why are some revisions marked ok by no one? :S
Modified paths:
  • /trunk/phase3/includes/Autopromote.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Autopromote.php
——@@ -74,7 +74,7 @@
7575 }
7676
7777 return $res;
78 - } elseif ( $cond[0] = '!' ) {
 78+ } elseif ( $cond[0] == '!' ) {
7979 foreach ( array_slice( $cond, 1 ) as $subcond ) {
8080 if ( self::recCheckCondition( $subcond, $user ) ) {
8181 return false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r35983Add a ! operator to autopromote conditionswerdna05:13, 7 June 2008

Comments

#Comment by Gurch (talk | contribs)   21:36, 13 October 2010

AFAIK all revisions from before the code review system was put in place are marked "ok". Doesn't mean they are bug free of course :)

#Comment by Reedy (talk | contribs)   21:40, 13 October 2010

Nope. There's loads not marked. Hence why I added the "old" status =)

#Comment by Gurch (talk | contribs)   02:19, 14 October 2010

"old" only covers revisions up to r14928

r14929 - r22661 are mostly "new"

after that they start being OK but not marked by anyone, until around r43400 -- the time code review was introduced -- at which point the status change is logged

presumably revisions before that were set to OK somehow before you started doing the "old" thing

Status & tagging log