r74465 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74464‎ | r74465 | r74466 >
Date:21:16, 7 October 2010
Author:kaldari
Status:deferred (Comments)
Tags:
Comment:
fixing spacing
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumn.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumn.php
@@ -202,7 +202,7 @@
203203 // card logos
204204 $form .= '<tr>';
205205 $form .= '<td />';
206 - $form .= '<td>' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos.gif" )) . '</td>';
 206+ $form .= '<td>&nbsp;<br/>' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos.gif" )) . '</td>';
207207 $form .= '</tr>';
208208
209209 // card number

Comments

#Comment by Nikerabbit (talk | contribs)   06:01, 8 October 2010

Weren't named entities including   banned a while back? Should use   or css styles instead.

#Comment by P858snake (talk | contribs)   06:23, 8 October 2010

*Including  

#Comment by P858snake (talk | contribs)   06:24, 8 October 2010

It should say

   
#Comment by P858snake (talk | contribs)   06:25, 8 October 2010

nowiki and pre are both rendering it >.<, it should say "& nbsp;"

Status & tagging log