r74338 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74337‎ | r74338 | r74339 >
Date:06:09, 6 October 2010
Author:kaldari
Status:deferred (Comments)
Tags:
Comment:
a bit more concise
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter.php
@@ -143,13 +143,11 @@
144144 $form .= Xml::closeElement( 'form' ); // close form 'payment'
145145 $form .= <<<EOT
146146 <script type="text/javascript">
147 -var fname = document.getElementById('fname');
148 -var lname = document.getElementById('lname');
149 -if (fname.value == '') {
 147+if (document.getElementById('fname').value == '') {
150148 fname.style.color = '#999999';
151149 fname.value = 'First';
152150 }
153 -if (lname.value == '') {
 151+if (document.getElementById('lname').value == '') {
154152 lname.style.color = '#999999';
155153 lname.value = 'Last';
156154 }

Comments

#Comment by MZMcBride (talk | contribs)   06:28, 6 October 2010

Looks like this was reverted by r74339.

Status & tagging log