r74320 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r74319‎ | r74320 | r74321 >
Date:18:57, 5 October 2010
Author:kaldari
Status:deferred (Comments)
Tags:
Comment:
fix for r74277 and r74110
Modified paths:
  • /trunk/extensions/CentralNotice/centralnotice.js (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/centralnotice.js
——@@ -26,7 +26,7 @@
2727 var buttonValue = '[<a href="#" onclick="toggleNotice();return false">{{int:centralnotice-shared-hide}}</a>]';
2828 break;
2929 case 'close':
30 - var buttonValue = '<a href="#" onclick="toggleNotice();return false"><img border="0" src="http://bits.wikimedia.org/skins-1.5/common/closewindow.png" width="11" height="11" alt="Close" /></a>';
 30+ var buttonValue = '<a href="#" onclick="toggleNotice();return false">{{MediaWiki:centralnotice-shared-close}}</a>';
3131 break;
3232 }
3333 if (document.selection) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r79696removing wikimedia specific stuff per r74110, r74277, and r74320kaldari00:56, 6 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74110add in close button stuffkaldari21:27, 1 October 2010
r74277switching to icon on bits for better security/stability, per comment at r74110kaldari21:12, 4 October 2010

Comments

#Comment by Catrope (talk | contribs)   17:54, 23 October 2010

What is this even doing? The centralnotice-shared-close message doesn't exist.

What you should be doing here is use a local path to the image rather than the bits.wm.o path. No need to mess around with messages.

#Comment by MZMcBride (talk | contribs)   17:57, 23 October 2010

It exists where it needs to exist: http://meta.wikimedia.org/wiki/MediaWiki:Centralnotice-shared-close

#Comment by Catrope (talk | contribs)   18:03, 23 October 2010

Right and that's just ugly.

Status & tagging log