r74191 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74190‎ | r74191 | r74192 >
Date:08:42, 3 October 2010
Author:ialex
Status:ok
Tags:
Comment:
Added wfDeprecated() to wfAbruptExit() and wfErrorExit() and removed a comment that mentioned it
Modified paths:
  • /trunk/phase3/includes/Exception.php (modified) (history)
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -937,6 +937,7 @@
938938 }
939939 $called = true;
940940
 941+ wfDeprecated( __FUNCTION__ );
941942 $bt = wfDebugBacktrace();
942943 if( $bt ) {
943944 for( $i = 0; $i < count( $bt ); $i++ ) {
@@ -960,6 +961,7 @@
961962 * @deprecated Please return control the caller or throw an exception
962963 */
963964 function wfErrorExit() {
 965+ wfDeprecated( __FUNCTION__ );
964966 wfAbruptExit( true );
965967 }
966968
Index: trunk/phase3/includes/Exception.php
@@ -388,7 +388,7 @@
389389
390390 wfReportException( $e );
391391
392 - // Final cleanup, similar to wfErrorExit()
 392+ // Final cleanup
393393 if ( $wgFullyInitialised ) {
394394 try {
395395 wfLogProfilingData(); // uses $wgRequest, hence the $wgFullyInitialised condition

Follow-up revisions

RevisionCommit summaryAuthorDate
r74193Per Nikerabbit, follow-up to r74191: tag for removal in 1.19; I removed the l...ialex08:50, 3 October 2010

Status & tagging log