r74177 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74176‎ | r74177 | r74178 >
Date:23:23, 2 October 2010
Author:siebrand
Status:reverted (Comments)
Tags:
Comment:
Use 7*24*3600 instead of 604800.

Addressing style nitpick by Simetrical on r71412.
Modified paths:
  • /trunk/phase3/includes/MessageCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/MessageCache.php
@@ -52,7 +52,7 @@
5353 * better sample, but also takes longer to adapt changes. The counts
5454 * are aggregrated per day, regardless of the value of this variable.
5555 */
56 - protected static $mAdaptiveDataAge = 604800;
 56+ protected static $mAdaptiveDataAge = 7*24*3600;
5757
5858 /**
5959 * Filter the tail of less used messages that are requested more seldom

Follow-up revisions

RevisionCommit summaryAuthorDate
r74179Fix broken r74177 because it needs a constant and address CR comment on r7141...siebrand23:34, 2 October 2010
r814441.17: Back out r71412 (adaptive message cache) and its followups r71418, r741...catrope11:58, 3 February 2011
r925491.18: Back out adaptive message cache (r71412, r71418, r74177, r74179) by mer...catrope18:35, 19 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71412Added $wgAdaptiveMessageCache to avoid caching huge pile of never used messag...nikerabbit16:41, 21 August 2010

Comments

#Comment by Siebrand (talk | contribs)   23:28, 2 October 2010

Broken, but why? PHP Parse error: syntax error, unexpected '*', expecting ',' or ';' in /www/w/includes/MessageCache.php on line 55

Status & tagging log