r74142 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74141‎ | r74142 | r74143 >
Date:14:16, 2 October 2010
Author:dale
Status:resolved (Comments)
Tags:
Comment:
fixed font size
updated version number
Modified paths:
  • /branches/MwEmbedStandAlone/modules/SmilPlayer/mw.SmilLayout.js (modified) (history)
  • /branches/MwEmbedStandAlone/remotes/mediaWiki.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/SmilPlayer/mw.SmilLayout.js
@@ -520,7 +520,25 @@
521521 'height' :imageTargetHeight
522522 })
523523 });
524 - })
 524+ });
 525+ // Switch any named font-size attribute to em
 526+ /*$htmlLayout.find('[style]').each( function(inx, node){
 527+ if( $j(node).css('font-size') ){
 528+ if( _this.emFontSizeMap[ $j(node).css('font-size') ] ){
 529+ $j(node).css('font-size', _this.emFontSizeMap[ $j(node).css('font-size') ] );
 530+ } else {
 531+ //@@ todo translate absolute pixle size to relative
 532+ }
 533+ }
 534+ });*/
 535+ // Switch any named font-size attribute to relative pixle size
 536+ $htmlLayout.find('[style]').each( function(inx, node){
 537+ if( $j(node).css('font-size') ){
 538+ $j(node).css('font-size',
 539+ ( fontScalePercent * parseFloat( $j(node).css('font-size') ) ) + 'px'
 540+ );
 541+ }
 542+ })
525543
526544 // Strip any links for thumbs of player
527545 $htmlLayout.find('a').attr('href', '#');
@@ -953,7 +971,7 @@
954972 'textColor' : 'color',
955973 'textFontSize' : 'font-size',
956974 'textFontStyle' : 'font-style'
957 - }
 975+ };
958976
959977 var cssAttributes = {};
960978 for(var i =0; i < $smilElement[0].attributes.length; i++ ){
Index: branches/MwEmbedStandAlone/remotes/mediaWiki.js
@@ -4,7 +4,7 @@
55 */
66 var urlparts = getRemoteEmbedPath();
77 var mwEmbedHostPath = urlparts[0];
8 -var mwRemoteVersion = 'r155';
 8+var mwRemoteVersion = 'r156';
99 var mwUseScriptLoader = true;
1010
1111 // Log the mwRemote version makes it easy to debug cache issues

Comments

#Comment by Brion VIBBER (talk | contribs)   01:06, 3 October 2010

There's a tab/spacing mismatch, and addition of commented-out dead code.

#Comment by Mdale (talk | contribs)   14:12, 3 October 2010

Hi Brion! ... ops copy and pasted some bad spaces. fixed in r74202

Status & tagging log