r73823 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73822‎ | r73823 | r73824 >
Date:19:50, 27 September 2010
Author:kaldari
Status:ok
Tags:
Comment:
using strict comparison per comment at r73266
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialBannerAllocation.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialBannerAllocation.php
@@ -63,7 +63,7 @@
6464 $htmlOut .= Xml::openElement( 'td' );
6565 $htmlOut .= Xml::openElement( 'select', array( 'name' => 'project' ) );
6666 foreach ( $wgNoticeProjects as $value ) {
67 - $htmlOut .= Xml::option( $value, $value, $value == $this->project );
 67+ $htmlOut .= Xml::option( $value, $value, $value === $this->project );
6868 }
6969 $htmlOut .= Xml::closeElement( 'select' );
7070 $htmlOut .= Xml::closeElement( 'td' );
@@ -79,7 +79,7 @@
8080 ksort( $languages );
8181 $htmlOut .= Xml::openElement( 'select', array( 'name' => 'language' ) );
8282 foreach( $languages as $code => $name ) {
83 - $htmlOut .= Xml::option( wfMsg( 'centralnotice-language-listing', $code, $name ), $code, $code == $this->language );
 83+ $htmlOut .= Xml::option( wfMsg( 'centralnotice-language-listing', $code, $name ), $code, $code === $this->language );
8484 }
8585 $htmlOut .= Xml::closeElement( 'select' );
8686 $htmlOut .= Xml::closeElement( 'td' );
@@ -90,7 +90,7 @@
9191 $countries = CentralNoticeDB::getCountriesList();
9292 $htmlOut .= Xml::openElement( 'select', array( 'name' => 'country' ) );
9393 foreach( $countries as $code => $name ) {
94 - $htmlOut .= Xml::option( $name, $code, $code == $this->location );
 94+ $htmlOut .= Xml::option( $name, $code, $code === $this->location );
9595 }
9696 $htmlOut .= Xml::closeElement( 'select' );
9797 $htmlOut .= Xml::closeElement( 'td' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73266more preliminary code for banner allocation viewer (not localizable yet)kaldari01:04, 18 September 2010

Status & tagging log