r73812 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73811‎ | r73812 | r73813 >
Date:15:14, 27 September 2010
Author:ashley
Status:ok (Comments)
Tags:
Comment:
ProofreadPage: follow-up to r73811 - tweak coding style
Modified paths:
  • /trunk/extensions/ProofreadPage/proofread.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/proofread.js
@@ -95,7 +95,7 @@
9696 pageBody = text;
9797 pageFooter = proofreadPageFooter;
9898 if( document.editform ) {
99 - document.editform.elements['wpSummary'].value = "/* " + mediaWiki.msg.get( 'proofreadpage_quality1_category' ) + " */ ";
 99+ document.editform.elements['wpSummary'].value = '/* ' + mediaWiki.msg.get( 'proofreadpage_quality1_category' ) + ' */ ';
100100 }
101101 }
102102 }
@@ -166,7 +166,11 @@
167167 pageHeader = pageHeader.split( '&' ).join( '&' );
168168 pageFooter = pageFooter.split( '&' ).join( '&' );
169169
170 - if ( ! self.proofreadpage_show_headers ) headers_style = 'display:none'; else headers_style='';
 170+ if ( !self.proofreadpage_show_headers ) {
 171+ headers_style = 'display:none';
 172+ } else {
 173+ headers_style = '';
 174+ }
171175
172176 container.innerHTML = '' +
173177 '<div id="prp_header" style="' + headers_style + '">' +
@@ -601,7 +605,7 @@
602606 }
603607 }
604608
605 -self.pr_zoom = function(delta) {
 609+self.pr_zoom = function( delta ) {
606610 if ( delta == 0 ) {
607611 // reduce width by 20 pixels in order to prevent horizontal scrollbar
608612 // from showing up
@@ -776,7 +780,7 @@
777781 pr_container.addEventListener( 'DOMMouseScroll', pr_zoom_wheel, false );
778782 }
779783 pr_container.onmousewheel = pr_zoom_wheel; // IE, Opera.
780 - pr_load_image(view_url);
 784+ pr_load_image( view_url );
781785 }
782786
783787 table.setAttribute( 'id', 'textBoxTable' );
@@ -959,19 +963,19 @@
960964 var text = '';
961965 switch( value ) {
962966 case 0:
963 - text = mediaWiki.msg.get( 'proofreadpage_quality0_category' );
 967+ text = mediaWiki.msg.get( 'proofreadpage_quality0_category' );
964968 break;
965969 case 1:
966 - text = mediaWiki.msg.get( 'proofreadpage_quality1_category' );
 970+ text = mediaWiki.msg.get( 'proofreadpage_quality1_category' );
967971 break;
968972 case 2:
969 - text = mediaWiki.msg.get( 'proofreadpage_quality2_category' );
 973+ text = mediaWiki.msg.get( 'proofreadpage_quality2_category' );
970974 break;
971975 case 3:
972 - text = mediaWiki.msg.get( 'proofreadpage_quality3_category' );
 976+ text = mediaWiki.msg.get( 'proofreadpage_quality3_category' );
973977 break;
974978 case 4:
975 - text = mediaWiki.msg.get( 'proofreadpage_quality4_category' );
 979+ text = mediaWiki.msg.get( 'proofreadpage_quality4_category' );
976980 break;
977981 }
978982 form.elements['wpSummary'].value = '/* ' + text + ' */ ';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73811use Resource loader ; adapt scriptsthomasv15:08, 27 September 2010

Comments

#Comment by Brion VIBBER (talk | contribs)   04:55, 28 September 2010

woops that's wrong resolution

Status & tagging log