| Index: trunk/phase3/includes/api/ApiFormatXml.php |
| — | — | @@ -155,7 +155,7 @@ |
| 156 | 156 | $retval .= self::recXmlPrint( $subElemId, $subElemValue, $indent ); |
| 157 | 157 | } |
| 158 | 158 | |
| 159 | | - foreach ( $indElements as $subElemId => & $subElemValue ) { |
| | 159 | + foreach ( $indElements as &$subElemValue ) { |
| 160 | 160 | $retval .= self::recXmlPrint( $subElemIndName, $subElemValue, $indent ); |
| 161 | 161 | } |
| 162 | 162 | |
| Index: trunk/phase3/includes/api/ApiMain.php |
| — | — | @@ -583,7 +583,7 @@ |
| 584 | 584 | |
| 585 | 585 | /** |
| 586 | 586 | * Check for sufficient permissions to execute |
| 587 | | - * @param $module object An Api module |
| | 587 | + * @param $module ApiBase An Api module |
| 588 | 588 | */ |
| 589 | 589 | protected function checkExecutePermissions( $module ) { |
| 590 | 590 | global $wgUser; |
| — | — | @@ -607,7 +607,7 @@ |
| 608 | 608 | |
| 609 | 609 | /** |
| 610 | 610 | * Check POST for external response and setup result printer |
| 611 | | - * @param $module object An Api module |
| | 611 | + * @param $module ApiBase An Api module |
| 612 | 612 | * @param $params Array an array with the request parameters |
| 613 | 613 | */ |
| 614 | 614 | protected function setupExternalResponse( $module, $params ) { |
| Index: trunk/phase3/includes/api/ApiQueryImageInfo.php |
| — | — | @@ -264,6 +264,11 @@ |
| 265 | 265 | return $vals; |
| 266 | 266 | } |
| 267 | 267 | |
| | 268 | + /* |
| | 269 | + * |
| | 270 | + * param $metadata Array |
| | 271 | + * param $result ApiResult |
| | 272 | + */ |
| 268 | 273 | public static function processMetaData( $metadata, $result ) { |
| 269 | 274 | $retval = array(); |
| 270 | 275 | if ( is_array( $metadata ) ) { |
| Index: trunk/phase3/includes/api/ApiUpload.php |
| — | — | @@ -285,7 +285,7 @@ |
| 286 | 286 | |
| 287 | 287 | if ( isset( $warnings['duplicate'] ) ) { |
| 288 | 288 | $dupes = array(); |
| 289 | | - foreach ( $warnings['duplicate'] as $key => $dupe ) { |
| | 289 | + foreach ( $warnings['duplicate'] as $dupe ) { |
| 290 | 290 | $dupes[] = $dupe->getName(); |
| 291 | 291 | } |
| 292 | 292 | $this->getResult()->setIndexedTagName( $dupes, 'duplicate' ); |