r73702 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73701‎ | r73702 | r73703 >
Date:02:10, 25 September 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r73699
Modified paths:
  • /trunk/extensions/Maps/Maps.php (modified) (history)
  • /trunk/extensions/Maps/includes/parserHooks/Maps_DisplayPoint.php (modified) (history)
  • /trunk/extensions/Maps/includes/services/GoogleMaps/Maps_GoogleMaps.php (modified) (history)
  • /trunk/extensions/Maps/includes/services/GoogleMaps3/Maps_GoogleMaps3.php (modified) (history)
  • /trunk/extensions/Maps/includes/services/OpenLayers/Maps_OpenLayers.php (modified) (history)
  • /trunk/extensions/Maps/includes/services/YahooMaps/Maps_YahooMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Maps.php
@@ -117,6 +117,10 @@
118118 $wgAutoloadClasses['MapsGoogleGeocoder'] = $geoDir . 'Maps_GoogleGeocoder.php';
119119 $wgAutoloadClasses['MapsYahooGeocoder'] = $geoDir . 'Maps_YahooGeocoder.php';
120120
 121+ // Autoload the "includes/manipulations/" classes.
 122+ $manDir = $incDir . 'manipulations/';
 123+ $wgAutoloadClasses['MapsParamService'] = $manDir . 'Maps_ParamService.php';
 124+
121125 // Autoload the "includes/parserHooks/" classes.
122126 $phDir = $incDir . '/parserHooks/';
123127 $wgAutoloadClasses['MapsCoordinates'] = $phDir . 'Maps_Coordinates.php';
@@ -158,8 +162,9 @@
159163 'description' => wfMsgExt( 'maps_desc', 'parsemag', $servicesList ),
160164 );
161165
162 - Validator::addOutputFormat( 'mapdimension', array( 'MapsMapper', 'setMapDimension' ) );
163 - Validator::addOutputFormat( 'coordinateset', array( 'MapsMapper', 'formatLocation' ) );
 166+ // TODO
 167+ //Validator::addOutputFormat( 'mapdimension', array( 'MapsMapper', 'setMapDimension' ) );
 168+ //Validator::addOutputFormat( 'coordinateset', array( 'MapsMapper', 'formatLocation' ) );
164169
165170 return true;
166171 }
Index: trunk/extensions/Maps/includes/services/GoogleMaps3/Maps_GoogleMaps3.php
@@ -45,8 +45,9 @@
4646 protected function initParameterInfo( array &$params ) {
4747 global $egMapsGMaps3Type, $egMapsGMaps3Types;
4848
49 - Validator::addOutputFormat( 'gmap3type', array( __CLASS__, 'setGMapType' ) );
50 - Validator::addOutputFormat( 'gmap3types', array( __CLASS__, 'setGMapTypes' ) );
 49+ // TODO
 50+ //Validator::addOutputFormat( 'gmap3type', array( __CLASS__, 'setGMapType' ) );
 51+ //Validator::addOutputFormat( 'gmap3types', array( __CLASS__, 'setGMapTypes' ) );
5152
5253 $params['type'] = new Parameter(
5354 'type',
Index: trunk/extensions/Maps/includes/services/YahooMaps/Maps_YahooMaps.php
@@ -43,8 +43,9 @@
4444 protected function initParameterInfo( array &$params ) {
4545 global $egMapsYahooAutozoom, $egMapsYahooMapsType, $egMapsYahooMapsTypes, $egMapsYahooMapsZoom, $egMapsYMapControls;
4646
47 - Validator::addOutputFormat( 'ymaptype', array( __CLASS__, 'setYMapType' ) );
48 - Validator::addOutputFormat( 'ymaptypes', array( __CLASS__, 'setYMapTypes' ) );
 47+ // TODO
 48+ //Validator::addOutputFormat( 'ymaptype', array( __CLASS__, 'setYMapType' ) );
 49+ //Validator::addOutputFormat( 'ymaptypes', array( __CLASS__, 'setYMapTypes' ) );
4950
5051 //$params['zoom']->addCriterion( new CriterionInRange( 1, 13 ) );
5152 //$params['zoom']->setDefault( self::getDefaultZoom() );
Index: trunk/extensions/Maps/includes/services/OpenLayers/Maps_OpenLayers.php
@@ -43,7 +43,8 @@
4444 protected function initParameterInfo( array &$params ) {
4545 global $egMapsOLLayers, $egMapsOLControls, $egMapsOpenLayersZoom;
4646
47 - Validator::addOutputFormat( 'olgroups', array( __CLASS__, 'unpackLayerGroups' ) );
 47+ // TODO
 48+ //Validator::addOutputFormat( 'olgroups', array( __CLASS__, 'unpackLayerGroups' ) );
4849
4950 //$params['zoom']->addCriterion( new CriterionInRange( 0, 19 ) );
5051 //$params['zoom']->setDefault( self::getDefaultZoom() );
Index: trunk/extensions/Maps/includes/services/GoogleMaps/Maps_GoogleMaps.php
@@ -57,8 +57,9 @@
5858 protected function initParameterInfo( array &$params ) {
5959 global $egMapsGoogleMapsType, $egMapsGoogleMapsTypes, $egMapsGoogleAutozoom, $egMapsGMapControls;
6060
61 - Validator::addOutputFormat( 'gmaptype', array( __CLASS__, 'setGMapType' ) );
62 - Validator::addOutputFormat( 'gmaptypes', array( __CLASS__, 'setGMapTypes' ) );
 61+ // TODO
 62+ //Validator::addOutputFormat( 'gmaptype', array( __CLASS__, 'setGMapType' ) );
 63+ //Validator::addOutputFormat( 'gmaptypes', array( __CLASS__, 'setGMapTypes' ) );
6364
6465 //$params['zoom']->addCriterion( new CriterionInRange( 0, 20 ) );
6566 //$params['zoom']->setDefault( self::getDefaultZoom() );
Index: trunk/extensions/Maps/includes/parserHooks/Maps_DisplayPoint.php
@@ -87,7 +87,7 @@
8888 global $egMapsMapWidth, $egMapsMapHeight, $egMapsDefaultServices, $egMapsDefaultTitle, $egMapsDefaultLabel;
8989
9090 // TODO
91 - Validator::addOutputFormat( 'geoPoints', array( __CLASS__, 'formatGeoPoints' ) );
 91+ //Validator::addOutputFormat( 'geoPoints', array( __CLASS__, 'formatGeoPoints' ) );
9292
9393 $params = MapsMapper::getCommonParameters();
9494

Follow-up revisions

RevisionCommit summaryAuthorDate
r73706Follow up to r73702jeroendedauw02:45, 25 September 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73699Follow up to r73697jeroendedauw01:42, 25 September 2010

Status & tagging log