r73667 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73666‎ | r73667 | r73668 >
Date:17:21, 24 September 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
CHanges for 0.7 - follow up to r73665
Modified paths:
  • /trunk/extensions/Maps/includes/parserHooks/Maps_Finddestination.php (modified) (history)
  • /trunk/extensions/Maps/includes/parserHooks/Maps_Geocode.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/includes/parserHooks/Maps_Finddestination.php
@@ -152,7 +152,11 @@
153153 $canGeocode = MapsMapper::geocoderIsAvailable();
154154
155155 if ( $canGeocode ) {
156 - $location = MapsGeocoders::attemptToGeocode( $parameters['location'] );
 156+ $location = MapsGeocoders::attemptToGeocode(
 157+ $parameters['location'],
 158+ $parameters['geoservice'],
 159+ $parameters['mappingservice']
 160+ );
157161 } else {
158162 $location = MapsCoordinateParser::parseCoordinates( $parameters['location'] );
159163 }
Index: trunk/extensions/Maps/includes/parserHooks/Maps_Geocode.php
@@ -143,7 +143,7 @@
144144 if ( MapsGeocoders::canGeocode() ) {
145145 $geovalues = MapsGeocoders::attemptToGeocodeToString(
146146 $parameters['location'],
147 - $parameters['service'],
 147+ $parameters['geoservice'],
148148 $parameters['mappingservice'],
149149 $parameters['allowcoordinates'],
150150 $parameters['format'],

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73665Changes for 0.7 - fixed small issue caused by parameter rename some commits backjeroendedauw17:15, 24 September 2010

Status & tagging log