r73666 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73665‎ | r73666 | r73667 >
Date:17:19, 24 September 2010
Author:tparscal
Status:resolved
Tags:
Comment:
Fixed issue in r73645 where an unset value was being returned in some cases.
Modified paths:
  • /trunk/phase3/includes/ResourceLoaderModule.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ResourceLoaderModule.php
@@ -157,9 +157,9 @@
158158 ), __METHOD__
159159 );
160160 if ( !is_null( $deps ) ) {
161 - $this->fileDeps[$skin] = (array) FormatJson::decode( $deps, true );
 161+ return $this->fileDeps[$skin] = (array) FormatJson::decode( $deps, true );
162162 }
163 - return $this->fileDeps[$skin];
 163+ return array();
164164 }
165165
166166 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73645Improved the performance of ResourceLoader by pre-loading module information ...tparscal21:23, 23 September 2010

Status & tagging log