r73562 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r73561‎ | r73562 | r73563 >
Date:19:15, 22 September 2010
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Improves on fix for bug #25246 by reducing the power of the foreground color rule - it was overriding the placeholder class.
Modified paths:
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/screen.css
——@@ -364,6 +364,9 @@
365365 top: 0.25em;
366366 }
367367 div#simpleSearch .placeholder {
 368+ color: black;
 369+ }
 370+ div#simpleSearch .placeholder {
368371 color: #999999;
369372 }
370373 div#simpleSearch input::-webkit-input-placeholder {
——@@ -381,7 +384,6 @@
382385 font-size: 13px;
383386 width: 14em;
384387 background-color: transparent;
385 - color: black;
386388 }
387389 /* OVERRIDDEN BY COMPLIANT BROWSERS */
388390 div#simpleSearch button#searchButton {

Follow-up revisions

RevisionCommit summaryAuthorDate
r73566Actually improves on fix for bug #25246 by reducing the power of the foregrou...tparscal20:11, 22 September 2010

Comments

#Comment by Nikerabbit (talk | contribs)   19:46, 22 September 2010

What is the purpose of two div#simpleSearch .placeholder { rules?

#Comment by Trevor Parscal (WMF) (talk | contribs)   20:11, 22 September 2010

Arg! Stupid mistake. Fixed now.

Status & tagging log