r73560 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r73559‎ | r73560 | r73561 >
Date:19:00, 22 September 2010
Author:foxtrott
Status:deferred (Comments)
Tags:
Comment:
Corrected french long date format.
Modified paths:
  • /trunk/extensions/SemanticFormsInputs/SemanticFormsInputs.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticFormsInputs/SemanticFormsInputs.i18n.php
——@@ -125,7 +125,7 @@
126126 'semanticformsinputs-prev' => 'Précédent',
127127 'semanticformsinputs-next' => 'Suivant',
128128 'semanticformsinputs-today' => "Aujourd'hui",
129 - 'semanticformsinputs-dateformatlong' => 'j MM aa',
 129+ 'semanticformsinputs-dateformatlong' => 'd MM yy',
130130 'semanticformsinputs-dateformatshort' => 'dd / mm / yy',
131131 'semanticformsinputs-firstdayofweek' => '0',
132132 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r73647Follow-up r73560: Removed french long date format, included more verbose desc...foxtrott22:25, 23 September 2010

Comments

#Comment by Siebrand (talk | contribs)   19:57, 22 September 2010

I was wondering if SemanticFormsInputs cannot get this information from the Language class using some Language::getDate*(). Translations will probably get this wrong more often.

#Comment by Nikerabbit (talk | contribs)   19:59, 22 September 2010

The jQuery date format markup is naturally different and probably far less versatile than ours. I don't know if it would be possible to generate the dates ourselves.

#Comment by F.trott (talk | contribs)   08:52, 23 September 2010

I don't think the effort is warranted. Besides the pure effort for translating one code into the other, there would also be problems regarding the MW formats not supported by jQuery (e.g. all the non-Gregorian calendars), as nikerabbit pointed out already.

I will include a more prominent comment/warning in the qqq-messages. Lets see, if that works out.

I will also remove the french long date format altogether as it is equal to the standard format.

Status & tagging log