r73386 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73385‎ | r73386 | r73387 >
Date:17:23, 20 September 2010
Author:pdhanda
Status:ok
Tags:
Comment:
As per Nikerabbit's comment in r73260, is not needed by MessageCache
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/MessageTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/MessageTest.php
@@ -8,8 +8,7 @@
99 $wgLanguageCode = 'en'; # For mainpage to be 'Main Page'
1010 //Some test set this to a Stub Object. For this test we need the real deal
1111 $wgContLang = $wgLang = Language::factory( $wgLanguageCode );
12 - $wgMemc = new FakeMemCachedClient;
13 - $wgMessageCache = new MessageCache( $wgMemc, true, 3600 );
 12+ $wgMessageCache = new MessageCache( false, true, 3600 );
1413 }
1514
1615 function testExists() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r73540No need of $wgMemc after r73386....platonides16:06, 22 September 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73260Some changes so that tests don't die silently on ci.pdhanda23:36, 17 September 2010

Status & tagging log