r73267 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73266‎ | r73267 | r73268 >
Date:01:09, 18 September 2010
Author:adam
Status:ok (Comments)
Tags:
Comment:
removing debug code added in r73256
Modified paths:
  • /trunk/extensions/ArticleAssessmentPilot/js/ArticleAssessment.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleAssessmentPilot/js/ArticleAssessment.js
@@ -260,10 +260,6 @@
261261 },
262262 'afterGetRatingData' : function( data ) {
263263 var settings = $( '#article-assessment' ).data( 'articleAssessment-context' ).settings;
264 - if (data.error) {
265 - alert(data.error.code);
266 - }
267 -
268264 // add the correct data to the markup
269265 if ( data.query && data.query.articleassessment && data.query.articleassessment.length > 0 ) {
270266 for ( var r in data.query.articleassessment[0].ratings ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73256Add a little bulletproofing.bharris23:07, 17 September 2010

Comments

#Comment by Jorm (WMF) (talk | contribs)   01:10, 18 September 2010

d'oh!

This actually brings up something else: i was noticing that the SQL error was not bubbling up. I'm gonna do a think on how to handle that.

Status & tagging log