r73123 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73122‎ | r73123 | r73124 >
Date:17:20, 16 September 2010
Author:tparscal
Status:ok
Tags:
Comment:
Fixed API and test to work with characters as span elements rather than a elements - a change that was made in r65558. This solves bug #25186.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/tests/wikiEditor.toolbar.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js
@@ -150,7 +150,7 @@
151151 target += ' div.pages div[rel=' + data.page + '].page';
152152 if ( typeof data.character == 'string' ) {
153153 // Character
154 - target += ' a[rel=' + data.character + ']';
 154+ target += ' span[rel=' + data.character + ']';
155155 } else if ( typeof data.row == 'number' ) {
156156 // Table row
157157 target += ' table tr:not(:has(th)):eq(' + data.row + ')';
Index: trunk/extensions/UsabilityInitiative/js/tests/wikiEditor.toolbar.js
@@ -172,7 +172,7 @@
173173 'page': 'emoticons',
174174 'character': ':))'
175175 },
176 - 'test': '*[rel=info].section *[rel=emoticons].page a[rel=":))"]',
 176+ 'test': '*[rel=info].section *[rel=emoticons].page *[rel=":))"]',
177177 'pre': 1,
178178 'post': 0
179179 },

Follow-up revisions

RevisionCommit summaryAuthorDate
r73129Merged in changes from r73123tparscal17:22, 16 September 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65558Fixed another accesibility issue, now characters in the toolbar are rendered ...tparscal21:59, 26 April 2010

Status & tagging log