r73088 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73087‎ | r73088 | r73089 >
Date:20:14, 15 September 2010
Author:reedy
Status:ok
Tags:
Comment:
User ID needs to be a condition of the left join!
Modified paths:
  • /trunk/extensions/ArticleAssessmentPilot/api/ApiQueryArticleAssessment.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleAssessmentPilot/api/ApiQueryArticleAssessment.php
@@ -37,12 +37,12 @@
3838 $this->addWhereFld( 'aa_user_anon_token', $params['anontoken'] );
3939 }
4040
41 - $this->addWhereFld( 'aa_user_id', $wgUser->getId() );
4241 $this->addTables( 'article_assessment' );
4342 $this->addJoinConds( array(
4443 'article_assessment' => array( 'LEFT JOIN', array(
4544 'aa_page_id=aap_page_id',
46 - 'aa_rating_id=aap_rating_id' ) ),
 45+ 'aa_rating_id=aap_rating_id',
 46+ 'aa_user_id=' . $wgUser->getId() ) ),
4747 )
4848 );
4949

Follow-up revisions

RevisionCommit summaryAuthorDate
r73140Followup r73088, do same for anontokenreedy18:43, 16 September 2010

Status & tagging log