r72995 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72994‎ | r72995 | r72996 >
Date:17:25, 14 September 2010
Author:kaldari
Status:ok
Tags:
Comment:
fixing remaining issues from r72619, changing to lowercase var
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialBannerListLoader.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialBannerListLoader.php
@@ -70,7 +70,7 @@
7171 // Pull out values
7272 foreach ( $notices as $notice => $val ) {
7373 // Either match against ALL project or a specific project
74 - if ( $val['project'] == '' || $val['project'] == $this->project ) {
 74+ if ( $val['project'] === '' || $val['project'] == $this->project ) {
7575 $templates = $this->centralNoticeDB->selectTemplatesAssigned( $notice );
7676 break;
7777 }
@@ -93,7 +93,7 @@
9494 $templates = CentralNotice::selectNoticeTemplates( $this->project, $this->language, $this->location );
9595 }
9696
97 - return 'Banners = ' . json_encode( $templates );
 97+ return 'banners = ' . FormatJson::encode( $templates );
9898 }
9999
100100 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72619initial version of banner list loaderkaldari23:38, 8 September 2010

Status & tagging log