r72996 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72995‎ | r72996 | r72997 >
Date:17:25, 14 September 2010
Author:kaldari
Status:ok
Tags:
Comment:
fixing comments in SpecialBannerController
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialBannerController.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialBannerController.php
@@ -53,10 +53,8 @@
5454 },
5555 'fn': {
5656 'loadBanner': function( bannerName ) {
57 - // Get the requested banner from /centralnotice/banners/<bannername>/<wgUserLanguage>.js
 57+ // Get the requested banner
5858 var bannerPage = 'Special:BannerLoader?banner='+bannerName+'&userlang='+wgContentLanguage+'&sitename='+wgNoticeProject;
59 - //centralized version:
60 - //var bannerURL = 'http://meta.wikimedia.org/wiki/'+bannerPage;
6159 var bannerURL = wgArticlePath.replace( '$1', bannerPage );
6260 var request = $.ajax( {
6361 url: bannerURL,
@@ -70,8 +68,6 @@
7169 var listURL;
7270 var geoLocation = Geo.country; // pull the geo info
7371 var bannerListPage = 'Special:BannerListLoader?language='+wgContentLanguage+'&project='+wgNoticeProject+'&location='+geoLocation;
74 - //centralized version:
75 - //var bannerListURL = 'http://meta.wikimedia.org/wiki/'+bannerListPage;
7672 var bannerListURL = wgArticlePath.replace( '$1', bannerListPage );
7773 var request = $.ajax( {
7874 url: bannerListURL,

Status & tagging log