r72942 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72941‎ | r72942 | r72943 >
Date:23:41, 13 September 2010
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Added missing semi-colon in r72941
Modified paths:
  • /trunk/phase3/includes/ResourceLoader.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ResourceLoader.php
@@ -151,7 +151,7 @@
152152 if ( ( $loader = $module->getLoaderScript() ) !== false ) {
153153 $deps = json_encode( $module->getDependencies() );
154154 $version = wfTimestamp( TS_ISO_8601, round( $module->getModifiedTime( $context ), -2 ) );
155 - $scripts .= "( function( name, version, dependencies ) { $loader } )( '$name', '$version', $deps )";
 155+ $scripts .= "( function( name, version, dependencies ) { $loader } )( '$name', '$version', $deps );";
156156 }
157157 // Automatically register module
158158 else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72941Wrapped custom loaders in a function which provides name, version and statica...tparscal23:41, 13 September 2010

Comments

#Comment by Hashar (talk | contribs)   12:03, 26 September 2010

resolve r72941

Status & tagging log