r72929 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r72928‎ | r72929 | r72930 >
Date:19:36, 13 September 2010
Author:tparscal
Status:ok
Tags:
Comment:
Fixed bug #25147, a regression caused by r72743, where one of the type checks for the style argument of mediaWiki.loader.implement did not get changed to accept objects as well as strings.
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.js
——@@ -560,7 +560,7 @@
561561 registry[module].state = 'loaded';
562562 // Attach components
563563 registry[module].script = script;
564 - if ( typeof style === 'string' ) {
 564+ if ( typeof style === 'string' || typeof style === 'object' ) {
565565 registry[module].style = style;
566566 }
567567 if ( typeof localization === 'object' ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72743ResourceLoaderSiteModule now supports CSS too!tparscal20:18, 10 September 2010

Status & tagging log