r72928 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72927‎ | r72928 | r72929 >
Date:19:33, 13 September 2010
Author:adam
Status:ok
Tags:
Comment:
Killing RevID from the api request for getting ratings, removing unused stale messages, switching to the correct state msg and CSS changes to help tipsy look good in IE
Modified paths:
  • /trunk/extensions/ArticleAssessmentPilot/ArticleAssessmentPilot.i18n.php (modified) (history)
  • /trunk/extensions/ArticleAssessmentPilot/api/ApiQueryArticleAssessment.php (modified) (history)
  • /trunk/extensions/ArticleAssessmentPilot/css/ArticleAssessment.css (modified) (history)
  • /trunk/extensions/ArticleAssessmentPilot/js/ArticleAssessment.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleAssessmentPilot/ArticleAssessmentPilot.i18n.php
@@ -28,11 +28,6 @@
2929 # This special page doesn't exist yet, but it will soon.
3030 'articleassessment-featurefeedback' => 'Give us [[Special:Article Assessment Feedback|feedback]] about this feature.',
3131 'articleassessment-noratings' => '$1 ($2 {{PLURAL:$2|rating|ratings}})',
32 - # Some of these messages are unused in the code as it is but may be in the future depending on performance. They should still be translated.
33 - 'articleassessment-stalemessage-revisioncount' => "This article has been ''revised'' '''$1 times''' since you last reviewed it.
34 -You may wish to re-rate it.",
35 - 'articleassessment-stalemessage-greaterthancount' => "This article has been ''revised'' more than $1 times since you last reviewed it.
36 -You may wish to re-rate it.",
3732 'articleassessment-stalemessage-norevisioncount' => "This article has been ''revised'' since you last reviewed it.
3833 You may wish to re-rate it.",
3934
Index: trunk/extensions/ArticleAssessmentPilot/css/ArticleAssessment.css
@@ -11,6 +11,9 @@
1212 * $Build: 35 (2010-05-01)
1313 *
1414 */
 15+.article-assessment-wrapper {
 16+ min-width: 1036px;
 17+}
1518 .article-assessment-wrapper .ui-stars-star {
1619 float: left;
1720 display: block;
@@ -52,18 +55,10 @@
5356 /* End ui-stars styles */
5457
5558 /* Tipsy Styles */
56 -.tipsy { padding: 5px; font-size: 12px; position: absolute; z-index: 100000; }
 59+.tipsy { padding: 5px 5px 10px; font-size: 12px; position: absolute; z-index: 100000; overflow: visible; }
5760 .tipsy-inner { padding: 5px 8px 4px 8px; background-color: #d6f3ff; color: black; border: 1px solid #5dc9f4; max-width: 300px; text-align: left; }
58 -/* .tipsy-inner { border-radius: 3px; -moz-border-radius:3px; -webkit-border-radius:3px; } */
5961 .tipsy-arrow { position: absolute; background: url( '../images/arrow.gif' ) no-repeat top left; width: 13px; height: 13px; }
60 -.tipsy-n .tipsy-arrow { top: 0; left: 50%; margin-left: -4px; }
61 -.tipsy-nw .tipsy-arrow { top: 0; left: 10px; }
62 -.tipsy-ne .tipsy-arrow { top: 0; right: 10px; }
63 -.tipsy-s .tipsy-arrow { bottom: 0; left: 50%; margin-left: -4px; background-position: bottom left; }
64 -.tipsy-sw .tipsy-arrow { bottom: 0; left: 10px; background-position: bottom left; }
65 -.tipsy-se .tipsy-arrow { bottom: -7px; right: 10px; background-position: bottom left; }
66 -.tipsy-e .tipsy-arrow { top: 50%; margin-top: -4px; right: 0; width: 5px; height: 9px; background-position: top right; }
67 -.tipsy-w .tipsy-arrow { top: 50%; margin-top: -4px; left: 0; width: 5px; height: 9px; }
 62+.tipsy-se .tipsy-arrow { bottom: -2px; right: 10px; background-position: 0% 100%; }
6863
6964 /* End Tipsy styles */
7065 .article-assessment-wrapper #article-assessment-rate,
Index: trunk/extensions/ArticleAssessmentPilot/api/ApiQueryArticleAssessment.php
@@ -48,10 +48,6 @@
4949
5050 $this->addFields( array( 'aa_rating_value', 'aa_revision' ) );
5151
52 - if ( isset( $params['revid'] ) ) {
53 - $this->addWhereFld( 'aa_revision', $params['revid'] );
54 - }
55 -
5652 $this->addOption( 'ORDER BY', 'aa_revision DESC' );
5753 }
5854
@@ -133,10 +129,6 @@
134130 ApiBase::PARAM_ISMULTI => false,
135131 ApiBase::PARAM_TYPE => 'integer',
136132 ),
137 - 'revid' =>array(
138 - ApiBase::PARAM_ISMULTI => false,
139 - ApiBase::PARAM_TYPE => 'integer',
140 - ),
141133 'userrating' => false,
142134 'anontoken' => null,
143135 );
@@ -145,7 +137,6 @@
146138 public function getParamDescription() {
147139 return array(
148140 'pageid' => 'Page ID to get assessments for',
149 - 'revid' => 'Specific revision to get (used in conjunction with userrating param, otherwise ignored)',
150141 'userrating' => "Whether to get the current user's ratings for the specific rev/article",
151142 'anontoken' => 'Token for anonymous users',
152143 );
Index: trunk/extensions/ArticleAssessmentPilot/js/ArticleAssessment.js
@@ -272,7 +272,7 @@
273273 $( '.ui-stars-star-on' )
274274 .addClass( 'ui-stars-star-stale' );
275275 // add the stale message
276 - var msg = $.ArticleAssessment.fn.getMsg( 'articleassessment-stalemessage-revisioncount' );
 276+ var msg = $.ArticleAssessment.fn.getMsg( 'articleassessment-stalemessage-norevisioncount' );
277277 $.ArticleAssessment.fn.flashNotice( msg, { 'class': 'article-assessment-stale-msg' } );
278278 } else {
279279 // if it's not a stale rating, we want to make the stars blue

Status & tagging log