r72909 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r72908‎ | r72909 | r72910 >
Date:15:31, 13 September 2010
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Follow-up r72897: use PLURAL too
Modified paths:
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesEn.php
——@@ -1618,7 +1618,7 @@
16191619 'showhideselectedversions' => 'Show/hide selected revisions',
16201620 'editundo' => 'undo',
16211621 'diff-multi' => '({{PLURAL:$1|One intermediate revision|$1 intermediate revisions}} by {{PLURAL:$2|one user|$2 users}} not shown)',
1622 -'diff-multi-manyusers' => '($1 intermediate revisions by more than $2 {{PLURAL:$2|user|users}} not shown)',
 1622+'diff-multi-manyusers' => '({{PLURAL:$1|One intermediate revision|$1 intermediate revisions}} by more than $2 {{PLURAL:$2|user|users}} not shown)',
16231623
16241624 # Search results
16251625 'search-summary' => '', # do not translate or duplicate this message to other languages

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72897Followup r72866, make 100 in 100+ a param. Makes raising the limit easier :)demon14:21, 13 September 2010

Comments

#Comment by 😂 (talk | contribs)   15:34, 13 September 2010

One intermediate revision isn't possible with diff-multi-manyusers, the number will always be at least 101, so this isn't necessary in MessagesEn.

#Comment by Raymond (talk | contribs)   15:41, 13 September 2010

You are right for English. Even of 1 is not possible we need the PLURAL for other languages which have up to 5 plural forms.

#Comment by 😂 (talk | contribs)   15:44, 13 September 2010

I understand, I just didn't see why English needed it :)

I added some docs to MessagesQqq in r72866, but the key was wrong so they got removed in r72882. Will re-add.

Status & tagging log