r72873 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72872‎ | r72873 | r72874 >
Date:17:13, 12 September 2010
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Fix for r72870: seems I didn't see that updaters.inc was included in the config directory, same for ^demon when he removed do_all_updates() in r72539 ;)
Modified paths:
  • /trunk/phase3/config/Installer.php (modified) (history)
  • /trunk/phase3/config/new-index.php (modified) (history)

Diff [purge]

Index: trunk/phase3/config/Installer.php
@@ -277,9 +277,6 @@
278278 <p>Afterwards retry to start the <a href=\"\">setup</a>.</p>" );
279279 }
280280
281 -
282 -require_once( "$IP/maintenance/updaters.inc" );
283 -
284281 class ConfigData {
285282 function getEncoded( $data ) {
286283 # removing latin1 support, no need...
@@ -1236,7 +1233,14 @@
12371234 print "</ul><pre>\n";
12381235 chdir( ".." );
12391236 flush();
1240 - do_all_updates();
 1237+
 1238+ define( 'MW_NO_SETUP', true );
 1239+ $updater = DatabaseUpdater::newForDb( $wgDatabase, false );
 1240+ $updater->doUpdates();
 1241+ foreach( $updater->getPostDatabaseUpdateMaintenance() as $maint ) {
 1242+ call_user_func_array( array( new $maint, 'execute' ), array() );
 1243+ }
 1244+
12411245 chdir( "config" );
12421246 print "</pre>\n";
12431247 print "<ul><li>Finished update checks.</li>\n";
Index: trunk/phase3/config/new-index.php
@@ -9,7 +9,6 @@
1010
1111 chdir( ".." );
1212 require( './includes/WebStart.php' );
13 -require_once( './maintenance/updaters.inc' ); // sigh...
1413
1514 $installer = new WebInstaller( $wgRequest );
1615

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72539* do_all_updates() is dead...demon14:33, 7 September 2010
r72870GOOD BYE, dear old updaters.inc!...ialex16:24, 12 September 2010

Comments

#Comment by 😂 (talk | contribs)   17:31, 12 September 2010

No, I noticed. I just don't care about config/Installer.php anymore ;-)

Status & tagging log