r72829 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72828‎ | r72829 | r72830 >
Date:20:43, 11 September 2010
Author:reedy
Status:ok
Tags:
Comment:
Use $this->mOptions, and specify Maintenance class for location of DB_ADMIN constant
Modified paths:
  • /trunk/phase3/maintenance/update.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/update.php
@@ -24,7 +24,7 @@
2525 }
2626
2727 public function getDbType() {
28 - return self::DB_ADMIN;
 28+ return Maintenance::DB_ADMIN;
2929 }
3030
3131 public function execute() {
@@ -34,7 +34,7 @@
3535
3636 $this->output( "MediaWiki {$wgVersion} Updater\n\n" );
3737
38 - if ( !isset( $options['skip-compat-checks'] ) ) {
 38+ if ( !isset( $this->mOptions['skip-compat-checks'] ) ) {
3939 install_version_checks();
4040 } else {
4141 $this->output( "Skipping compatibility checks, proceed at your own risk (Ctrl+C to abort)\n" );

Follow-up revisions

RevisionCommit summaryAuthorDate
r72835Follow-up r72829: we also have the hasOption() method for thatialex21:56, 11 September 2010

Status & tagging log