r72811 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72810‎ | r72811 | r72812 >
Date:14:51, 11 September 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Fix half-working schema change patch
Modified paths:
  • /trunk/extensions/LiquidThreads/schema-changes/ums_conversation.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/schema-changes/ums_conversation.sql
@@ -2,9 +2,9 @@
33 -- Adds and populates the ums_conversation field, along with relevant indices.
44 ALTER TABLE /*_*/user_message_state ADD COLUMN ums_conversation int(8) unsigned NOT NULL DEFAULT 0;
55
6 -CREATE INDEX /*i*/ums_user_conversation ON /*$wgDBprefix*/user_message_state (ums_user,ums_conversation);
 6+CREATE INDEX /*i*/ums_user_conversation ON /*_*/user_message_state (ums_user,ums_conversation);
77 DROP INDEX /*i*/ums_user_conversation ON /*_*/user_message_state;
88
99 UPDATE /*_*/user_message_state, /*_*/thread
10 -SET user_message_state.ums_conversation = if(thread.thread_ancestor, thread.thread_ancestor, thread.thread_id)
11 -WHERE ums_conversation = 0 AND thread.thread_id = user_message_state.ums_thread;
 10+SET /*_*/user_message_state.ums_conversation = if(/*_*/thread.thread_ancestor, /*_*/thread.thread_ancestor, /*_*/thread.thread_id)
 11+WHERE ums_conversation = 0 AND /*_*/thread.thread_id = /*_*/user_message_state.ums_thread;

Status & tagging log