r72810 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72809‎ | r72810 | r72811 >
Date:14:31, 11 September 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Fix strict warning and small cleanups
Modified paths:
  • /trunk/extensions/ContributionScores/ContributionScores_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ContributionScores/ContributionScores_body.php
@@ -12,8 +12,7 @@
1313 * @ingroup Extensions
1414 * @author Tim Laqua <t.laqua@gmail.com>
1515 */
16 -class ContributionScores extends IncludableSpecialPage
17 -{
 16+class ContributionScores extends IncludableSpecialPage {
1817 public function __construct() {
1918 parent::__construct( 'ContributionScores' );
2019 }
@@ -101,7 +100,7 @@
102101 "<td>" . wfMsgHtml( 'contributionscores-changes' ) . "</td>\n" .
103102 "<td>" . wfMsgHtml( 'contributionscores-username' ) . "</td>\n";
104103
105 - $skin =& $wgUser->getSkin();
 104+ $skin = $wgUser->getSkin();
106105 $altrow = '';
107106 while ( $row = $dbr->fetchObject( $res ) ) {
108107 $output .= "</tr><tr class='{$altrow}'>\n<td class='content'>" .
@@ -140,8 +139,6 @@
141140 function execute( $par ) {
142141 global $wgRequest, $wgOut, $wgHooks;
143142
144 - wfLoadExtensionMessages( 'ContributionScores' );
145 -
146143 $this->setHeaders();
147144
148145 if( $this->including() ) {
@@ -201,7 +198,7 @@
202199 array(0,50));
203200 }
204201
205 - $wgOut->addWikiText( wfMsg( 'contributionscores-info' ) );
 202+ $wgOut->addWikiMsg( 'contributionscores-info' );
206203
207204 foreach ( $wgContribScoreReports as $scoreReport) {
208205 if ( $scoreReport[0] > 0 ) {

Status & tagging log