r72705 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72704‎ | r72705 | r72706 >
Date:09:46, 10 September 2010
Author:daniel
Status:ok
Tags:
Comment:
adoped test cases to interface changes introduced by r72526
Modified paths:
  • /trunk/extensions/PagedTiffHandler/tests/PagedTiffHandlerTest.php (modified) (history)

Diff [purge]

Index: trunk/extensions/PagedTiffHandler/tests/PagedTiffHandlerTest.php
@@ -232,9 +232,13 @@
233233 // ---- File upload checks and Thumbnail transformation
234234 // check
235235 // TODO: check other images
236 - $this->assertTrue( $this->handler->check( 'multipage.tiff', $this->multipage_path, $error ) );
237 - $this->assertFalse( $this->handler->check( 'Truncated.tiff', $this->truncated_path, $error ) );
238 - $this->assertEquals( $error, 'tiff_bad_file' );
 236+ $status = $this->handler->verifyUpload( $this->multipage_path );
 237+ $this->assertTrue( $status->isGood() );
 238+
 239+ $status = $this->handler->verifyUpload( $this->truncated_path );
 240+ $this->assertFalse( $status->isGood() );
 241+ $this->assertTrue( $status->hasMessage( 'tiff_bad_file' ) );
 242+
239243 // doTransform
240244 $this->handler->doTransform( $this->multipage_image, $this->test_path, 'Test.tif', array( 'width' => 100, 'height' => 100 ) );
241245 $error = $this->handler->doTransform( wfFindFile( Title::newFromText( 'Image:Truncated.tiff' ) ), $this->truncated_path, 'Truncated.tiff', array( 'width' => 100, 'height' => 100 ) );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72526* PagedTiffHandler update for core change r72525, fixes r72025....tstarling10:43, 7 September 2010

Status & tagging log