r72025 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72024‎ | r72025 | r72026 >
Date:14:09, 31 August 2010
Author:daniel
Status:resolved
Tags:
Comment:
use file verification via MediaHandler interface. requires r72024 in core.
Modified paths:
  • /trunk/extensions/PagedTiffHandler/PagedTiffHandler.php (modified) (history)
  • /trunk/extensions/PagedTiffHandler/PagedTiffHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/PagedTiffHandler/PagedTiffHandler_body.php
@@ -59,7 +59,7 @@
6060 * - identify-warnings
6161 * - check for running-identify-service
6262 */
63 - static function verifyFile( $upload, $mime, &$error ) {
 63+ function verifyFileHook( $upload, $mime, &$error ) {
6464 global $wgTiffMaxEmbedFiles, $wgTiffMaxMetaSize, $wgMaxUploadSize,
6565 $wgTiffRejectOnError, $wgTiffRejectOnWarning, $wgTiffUseTiffReader,
6666 $wgTiffReaderPath, $wgTiffReaderCheckEofForJS;
Index: trunk/extensions/PagedTiffHandler/PagedTiffHandler.php
@@ -121,7 +121,6 @@
122122 $wgAutoloadClasses['PagedTiffHandlerSeleniumTestSuite'] = $dir . 'selenium/PagedTiffHandlerTestSuite.php';
123123
124124 $wgMediaHandlers['image/tiff'] = 'PagedTiffHandler';
125 -$wgHooks['UploadVerifyFile'][] = 'PagedTiffHandler::verifyFile';
126125 $wgHooks['LanguageGetMagic'][] = 'PagedTiffHandler::addTiffLossyMagicWordLang';
127126
128127 define('TIFF_METADATA_VERSION', '1.0');

Follow-up revisions

RevisionCommit summaryAuthorDate
r72526* PagedTiffHandler update for core change r72525, fixes r72025....tstarling10:43, 7 September 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72024introducing Generic::verifyFileHook() to let media handlers do the verificati...daniel14:08, 31 August 2010

Status & tagging log