r72626 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r72625‎ | r72626 | r72627 >
Date:04:10, 9 September 2010
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Bug 25101 - Trim comments before saving
Modified paths:
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
——@@ -396,6 +396,7 @@
397397
398398 public function saveComment( $text, $review, $parent = null ) {
399399 global $wgUser;
 400+ $text = trim( $text );
400401 if ( !strlen( $text ) ) {
401402 return 0;
402403 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r79844Don't trim comments, rtrim them....reedy21:55, 7 January 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   21:49, 7 January 2011

per bug 26619 this should not trim leading whitespace, which is meaningful in wiki syntax. Change to rtrim()?

#Comment by Reedy (talk | contribs)   21:56, 7 January 2011

Fixed up in r79844

Status & tagging log