r72589 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72588‎ | r72589 | r72590 >
Date:16:35, 8 September 2010
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Fix spelling of max-age in Cache-Control: header. This inconsistency in the HTTP standard is retarded
Modified paths:
  • /trunk/phase3/includes/ResourceLoader.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ResourceLoader.php
@@ -258,7 +258,7 @@
259259
260260 header( 'Last-Modified: ' . wfTimestamp( TS_RFC2822, $mtime ) );
261261 $expires = wfTimestamp( TS_RFC2822, min( $maxage, $smaxage ) + time() );
262 - header( "Cache-Control: public, maxage=$maxage, s-maxage=$smaxage" );
 262+ header( "Cache-Control: public, max-age=$maxage, s-maxage=$smaxage" );
263263 header( "Expires: $expires" );
264264
265265 // Check if there's an If-Modified-Since header and respond with a 304 Not Modified if possible

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   23:28, 24 September 2010

Status & tagging log