r72319 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r72318‎ | r72319 | r72320 >
Date:21:53, 3 September 2010
Author:platonides
Status:resolved (Comments)
Tags:
Comment:
Remove call to deprecated function Linker::makeKnownLink from function specialLink.
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
——@@ -774,12 +774,9 @@
775775 * Usage example: $skin->specialLink( 'recentchanges' )
776776 */
777777 function specialLink( $name, $key = '' ) {
778 - global $wgContLang;
779 -
780778 if ( $key == '' ) { $key = strtolower( $name ); }
781 - $pn = $wgContLang->ucfirst( $name );
782 - return $this->makeKnownLink( $wgContLang->specialPage( $pn ),
783 - wfMsg( $key ) );
 779+
 780+ return $this->link( SpecialPage::getTitleFor( $name ) , wfMsg( $key ), array(), array(), array( 'known', 'noclasses' ) );
784781 }
785782
786783 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r72326Follow-up r72319. Use linkKnown() and skip a few parameters.platonides22:10, 3 September 2010

Comments

#Comment by Nikerabbit (talk | contribs)   22:01, 3 September 2010

If you use linkKnown() instead you can avoid the the three trailing arguments to the method.

#Comment by Platonides (talk | contribs)   22:10, 3 September 2010

I had just followed the @deprecated path to link(). Changed to linkKnown() in r72326.

Status & tagging log