r72055 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72054‎ | r72055 | r72056 >
Date:21:52, 31 August 2010
Author:adam
Status:ok (Comments)
Tags:
Comment:
Fix for bug 24906
Modified paths:
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -788,17 +788,6 @@
789789 'vector-action-protect' => 'Protect',
790790 'vector-action-undelete' => 'Undelete',
791791 'vector-action-unprotect' => 'Unprotect',
792 -'vector-namespace-category' => 'Category',
793 -'vector-namespace-help' => 'Help page',
794 -'vector-namespace-image' => 'File',
795 -'vector-namespace-main' => 'Page',
796 -'vector-namespace-media' => 'Media page',
797 -'vector-namespace-mediawiki' => 'Message',
798 -'vector-namespace-project' => 'Project page',
799 -'vector-namespace-special' => 'Special page',
800 -'vector-namespace-talk' => 'Discussion',
801 -'vector-namespace-template' => 'Template',
802 -'vector-namespace-user' => 'User page',
803792 'vector-simplesearch-preference' => 'Enable enhanced search suggestions (Vector skin only)',
804793 'vector-view-create' => 'Create',
805794 'vector-view-edit' => 'Edit',
Index: trunk/phase3/maintenance/language/messages.inc
@@ -179,17 +179,6 @@
180180 'vector-action-protect',
181181 'vector-action-undelete',
182182 'vector-action-unprotect',
183 - 'vector-namespace-category',
184 - 'vector-namespace-help',
185 - 'vector-namespace-image',
186 - 'vector-namespace-main',
187 - 'vector-namespace-media',
188 - 'vector-namespace-mediawiki',
189 - 'vector-namespace-project',
190 - 'vector-namespace-special',
191 - 'vector-namespace-talk',
192 - 'vector-namespace-template',
193 - 'vector-namespace-user',
194183 'vector-simplesearch-preference',
195184 'vector-view-create',
196185 'vector-view-edit',
Index: trunk/phase3/skins/Vector.php
@@ -106,11 +106,11 @@
107107
108108 // Adds namespace links
109109 $links['namespaces'][$subjectId] = $this->tabAction(
110 - $subjectPage, 'vector-namespace-' . $subjectId, !$isTalk, '', true
 110+ $subjectPage, 'nstab-' . $subjectId, !$isTalk, '', true
111111 );
112112 $links['namespaces'][$subjectId]['context'] = 'subject';
113113 $links['namespaces'][$talkId] = $this->tabAction(
114 - $talkPage, 'vector-namespace-talk', $isTalk, '', true
 114+ $talkPage, 'nstab-talk', $isTalk, '', true
115115 );
116116 $links['namespaces'][$talkId]['context'] = 'talk';
117117
@@ -312,7 +312,7 @@
313313 } else {
314314 $links['namespaces']['special'] = array(
315315 'class' => 'selected',
316 - 'text' => wfMsg( 'vector-namespace-special' ),
 316+ 'text' => wfMsg( 'nstab-special' ),
317317 'href' => $wgRequest->getRequestURL()
318318 );
319319 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r72059follow up to r72055 - fixing the discussion tabadam22:41, 31 August 2010
r721271.16wmf4: Merge r70633, r72043, r72055, r72059 from trunkcatrope17:52, 1 September 2010

Comments

#Comment by Aaron Schulz (talk | contribs)   22:32, 31 August 2010

Discussion tab looks wonky now.

Status & tagging log