r72014 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72013‎ | r72014 | r72015 >
Date:05:03, 31 August 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Fixed bug introduced in r72009
Modified paths:
  • /trunk/extensions/Maps/Includes/Maps_Mapper.php (modified) (history)
  • /trunk/extensions/Maps/Maps_Settings.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Includes/Maps_Mapper.php
@@ -81,7 +81,7 @@
8282 */
8383 public static function formatLocation( &$location, $name, array $parameters ) {
8484 if ( self::geocoderIsAvailable() ) {
85 - $location = MapsGeocoder::attemptToGeocodeToString( $location, $parameters['geoservice']['value'], $parameters['mappingservice']['value'] );
 85+ $location = MapsGeocoders::attemptToGeocodeToString( $location, $parameters['geoservice']['value'], $parameters['mappingservice']['value'] );
8686 } else {
8787 $location = MapsCoordinateParser::parseAndFormat( $location );
8888 }
@@ -173,7 +173,7 @@
174174 }
175175
176176 /**
177 - * Returns a boolean indicating if MapsGeocoder is available.
 177+ * Returns a boolean indicating if MapsGeocoders is available.
178178 *
179179 * @deprecated - use MapsGeocoders::canGeocode() instead
180180 *
Index: trunk/extensions/Maps/Maps_Settings.php
@@ -54,10 +54,17 @@
5555
5656 # Geocoders
5757
 58+ # Registration of the GeoNames service geocoder.
5859 $wgHooks['GeocoderFirstCallInit'][] = 'MapsGeonamesGeocoder::register';
 60+
 61+ # Registration of the Google Geocoding (v2) service geocoder.
5962 $wgHooks['GeocoderFirstCallInit'][] = 'MapsGoogleGeocoder::register';
 63+
 64+ # Registration of the Yahoo! Geocoding service geocoder.
6065 $wgHooks['GeocoderFirstCallInit'][] = 'MapsYahooGeocoder::register';
6166
 67+
 68+
6269 # Mapping services configuration
6370 # Note: You can not use aliases in the settings. Use the main service names.
6471

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72009Changes for 0.7 - rewrote the geocder functionalityjeroendedauw02:47, 31 August 2010

Status & tagging log