r71977 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71976‎ | r71977 | r71978 >
Date:20:53, 30 August 2010
Author:daniel
Status:ok (Comments)
Tags:
Comment:
removed some dead wood, as per comment on r71943
Modified paths:
  • /trunk/extensions/PagedTiffHandler/PagedTiffHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/PagedTiffHandler/PagedTiffHandler_body.php
@@ -94,15 +94,11 @@
9595 }
9696 }
9797 $meta = self::getTiffImage( false, $tempName )->retrieveMetaData();
98 - if ( !$meta && $meta != - 1 ) {
 98+ if ( !$meta ) {
9999 $error = array( 'tiff_out_of_service' );
100100 wfDebug( __METHOD__ . ": {$error[0]} ($saveName)\n" );
101101 return false;
102102 }
103 - if ( $meta == - 1 ) {
104 - $error = array( 'tiff_error_cached' );
105 - wfDebug( __METHOD__ . ": {$error[0]} ($saveName)\n" );
106 - }
107103
108104 $ok = self::verifyMetaData( $meta, $error, $saveName );
109105

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71943use new UploadVerifyFile hook, introduced in r71942daniel12:18, 30 August 2010

Comments

#Comment by Duesentrieb (talk | contribs)   20:54, 30 August 2010

as far as i can see, $meta == -1 is a relict of the "cache failures in the object cache" scheme, which we abondoned quite a while back

Status & tagging log