r71867 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r71866‎ | r71867 | r71868 >
Date:03:03, 29 August 2010
Author:werdna
Status:ok
Tags:
Comment:
Fix bug introduced in untested r71576. getNamespaces() did not use getCanonicalNamespaces for backwards-compatibility with 1.16wmf4 :-)
Modified paths:
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/Language.php
——@@ -262,6 +262,8 @@
263263 }
264264
265265 # Sometimes a language will be localised but not actually exist on this wiki.
 266+ global $wgCanonicalNamespaceNames;
 267+ $validNamespaces = array_keys(MWNamespace::getCanonicalNamespaces());
266268 foreach( $this->namespaceNames as $key => $text ) {
267269 if ( !isset( $validNamespaces[$key] ) ) {
268270 unset( $this->namespaceNames[$key] );

Follow-up revisions

RevisionCommit summaryAuthorDate
r71868Unmerging r71867. Merge-conflicts with some things Nikerabbit was doing. He b...werdna03:08, 29 August 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71576Added a hook into MWNamespace::getCanonicalNamespaces() to provide safe way to...nikerabbit19:58, 24 August 2010

Status & tagging log