r71644 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71643‎ | r71644 | r71645 >
Date:18:50, 25 August 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Replace todo with documentation with partial

Move brace
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
@@ -861,8 +861,7 @@
862862 * (e.g. array( 'page' => array('LEFT JOIN','page_latest=rev_id') )
863863 * @return mixed Database result resource (feed to DatabaseBase::fetchObject or whatever), or false on failure
864864 */
865 - function select( $table, $vars, $conds='', $fname = 'DatabaseBase::select', $options = array(), $join_conds = array() )
866 - {
 865+ function select( $table, $vars, $conds='', $fname = 'DatabaseBase::select', $options = array(), $join_conds = array() ) {
867866 $sql = $this->selectSQLText( $table, $vars, $conds, $fname, $options, $join_conds );
868867 return $this->query( $sql, $fname );
869868 }
@@ -1638,7 +1637,10 @@
16391638 * However if you do this, you run the risk of encountering errors which wouldn't have
16401639 * occurred in MySQL
16411640 *
1642 - * @todo migrate comment to phodocumentor format
 1641+ * @param $table String: The table to replace the row(s) in.
 1642+ * @param $uniqueIndexes String:
 1643+ * @param $rows Array: Array of rows to replace
 1644+ * @param $fname String: Calling function name (use __METHOD__) for logs/profiling
16431645 */
16441646 function replace( $table, $uniqueIndexes, $rows, $fname = 'DatabaseBase::replace' ) {
16451647 $table = $this->tableName( $table );

Follow-up revisions

RevisionCommit summaryAuthorDate
r71651Improve comment for $uniqueIndexes r71644reedy19:08, 25 August 2010

Comments

#Comment by Platonides (talk | contribs)   18:55, 25 August 2010

+ * @param $uniqueIndexes String:

The comment above says "an associative array $uniqueIndexes is an array of indexes", so not a String.

Status & tagging log