r71593 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71592‎ | r71593 | r71594 >
Date:22:04, 24 August 2010
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Move unreachable $this->mConn = false in DatabaseSqlite
Modified paths:
  • /trunk/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseSqlite.php
@@ -65,8 +65,8 @@
6666
6767 $fileName = self::generateFileName( $wgSQLiteDataDir, $dbName );
6868 if ( !is_readable( $fileName ) ) {
 69+ $this->mConn = false;
6970 throw new DBConnectionError( $this, "SQLite database not accessible" );
70 - $this->mConn = false;
7171 }
7272 $this->openFile( $fileName );
7373 return $this->mConn;

Follow-up revisions

RevisionCommit summaryAuthorDate
r71628Followup r71593 - Spaces, I *still* hate youreedy15:26, 25 August 2010

Comments

#Comment by Nikerabbit (talk | contribs)   06:21, 25 August 2010

Spaces here too :)

Status & tagging log