r71465 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r71464‎ | r71465 | r71466 >
Date:08:19, 23 August 2010
Author:thomasv
Status:ok (Comments)
Tags:
Comment:
follow-up to r71157
Modified paths:
  • /trunk/extensions/Cite/Cite_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Cite/Cite_body.php
——@@ -643,7 +643,7 @@
644644 $this->refKey( $key ),
645645 $val
646646 );
647 - else if ( $val['follow'] )
 647+ else if ( isset( $val['follow'] ) )
648648 return
649649 wfMsgForContentNoTrans(
650650 'cite_references_no_link',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71157Support for references spread on multiple transcluded pages, using the 'follo...thomasv12:05, 16 August 2010

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   19:26, 2 February 2011

While this doesn't throw errors when there's no follow key in $val, it will also not pay attention to the value of $val['follow'], meaning it's very presence makes this eval to true, no matter what the value - this seems suspicious.

#Comment by Trevor Parscal (WMF) (talk | contribs)   21:30, 3 February 2011

After looking over the rest of the code surrounding this change it looks more sane.

Status & tagging log