r71428 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71427‎ | r71428 | r71429 >
Date:10:06, 22 August 2010
Author:maxsem
Status:ok
Tags:
Comment:
"Difference between pages" is now displayed instead of "Difference between revisions" on diffs when appropriate. This is even more important now that we have Special:ComparePages
Modified paths:
  • /trunk/phase3/includes/diff/DifferenceInterface.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQqq.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -809,6 +809,7 @@
810810 'diffs' => array(
811811 'history-title',
812812 'difference',
 813+ 'difference-multipage',
813814 'lineno',
814815 'compareselectedversions',
815816 'showhideselectedversions',
Index: trunk/phase3/includes/diff/DifferenceInterface.php
@@ -186,7 +186,11 @@
187187 } else {
188188 $wgOut->setPageTitle( $oldTitle . ', ' . $newTitle );
189189 }
190 - $wgOut->setSubtitle( wfMsgExt( 'difference', array( 'parseinline' ) ) );
 190+ if ( $this->mNewPage->equals( $this->mOldPage ) ) {
 191+ $wgOut->setSubtitle( wfMsgExt( 'difference', array( 'parseinline' ) ) );
 192+ } else {
 193+ $wgOut->setSubtitle( wfMsgExt( 'difference-multipage', array( 'parseinline' ) ) );
 194+ }
191195 $wgOut->setRobotPolicy( 'noindex,nofollow' );
192196
193197 if ( !$this->mOldPage->userCanRead() || !$this->mNewPage->userCanRead() ) {
Index: trunk/phase3/languages/messages/MessagesQqq.php
@@ -1167,6 +1167,8 @@
11681168 # Diffs
11691169 'history-title' => 'Displayed as page title when you click on the "history" tab. The parameter $1 is the normal page title.',
11701170 'difference' => 'Displayed under the title when viewing the difference between two or more edits.',
 1171+'difference-multipage' => 'Displayed under the title when viewing the difference between two or more pages.
 1172+See also {{msg-mw|difference}}.',
11711173 'lineno' => 'Message used when comparing different versions of a page (diff). $1 is a line number.',
11721174 'compareselectedversions' => 'Used as button in history pages.',
11731175 'showhideselectedversions' => 'Text of the button which brings up the [[mw:RevisionDelete|RevisionDelete]] menu.',
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1624,6 +1624,7 @@
16251625 # Diffs
16261626 'history-title' => 'Revision history of "$1"',
16271627 'difference' => '(Difference between revisions)',
 1628+'difference-multipage' => '(Difference between pages)',
16281629 'lineno' => 'Line $1:',
16291630 'compareselectedversions' => 'Compare selected revisions',
16301631 'showhideselectedversions' => 'Show/hide selected revisions',

Follow-up revisions

RevisionCommit summaryAuthorDate
r71429Release notes for r71428maxsem10:07, 22 August 2010

Status & tagging log