r71369 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71368‎ | r71369 | r71370 >
Date:16:50, 20 August 2010
Author:demon
Status:deferred (Comments)
Tags:
Comment:
Fix regression from maintenance rewrite, fixLinksFromArticle is part of a class now
Modified paths:
  • /trunk/extensions/Distribution/includes/DistributionRelease.php (modified) (history)
  • /trunk/extensions/OAI/OAIHarvest.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OAI/OAIHarvest.php
@@ -39,7 +39,7 @@
4040
4141 # Need shared code...
4242 require_once( 'OAIFunctions.php' );
43 -require_once( "$IP/maintenance/refreshLinks.inc" );
 43+require_once( "$IP/maintenance/refreshLinks.php" );
4444
4545 global $oaiSourceRepository;
4646 global $oaiAgentExtra;
@@ -361,7 +361,7 @@
362362 $id = $this->applyRevision( $revision );
363363 }
364364
365 - fixLinksFromArticle( $id );
 365+ RefreshLinks::fixLinksFromArticle( $id );
366366
367367 if( isset( $this->_page['uploads'] ) ) {
368368 foreach( $this->_page['uploads'] as $upload ) {
Index: trunk/extensions/Distribution/includes/DistributionRelease.php
@@ -23,6 +23,13 @@
2424 * @author Jeroen De Dauw
2525 */
2626 class DistributionRelease {
 27+
 28+ const ST_DEV = 0;
 29+ const ST_ALPHA = 1;
 30+ const ST_BETA = 2;
 31+ const ST_RC = 3;
 32+ const ST_STABLE = 4;
 33+ const ST_DEPRECATED = 5;
2734
2835 /**
2936 * Mapping between the state names and internal representation.

Follow-up revisions

RevisionCommit summaryAuthorDate
r71370Followup r71369, unrelated changesdemon17:14, 20 August 2010

Comments

#Comment by Platonides (talk | contribs)   16:54, 20 August 2010

The addition of the constants should have been a separate commit?

#Comment by 😂 (talk | contribs)   17:13, 20 August 2010

Ugh I thought I had reverted that

Status & tagging log