r71218 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71217‎ | r71218 | r71219 >
Date:23:11, 17 August 2010
Author:awjrichards
Status:deferred
Tags:
Comment:
Switched 'serialize()' to 'json_encode()' for log messages in minfraud for easier portabiliyt/parsability
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/minfraud.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/minfraud.php
@@ -86,8 +86,8 @@
8787 if ( $this->log_fh ) {
8888 $log_message = '"' . addslashes( $data[ 'comment' ] ) . '"';
8989 $log_message .= "\t" . '"' . addslashes( $data[ 'amount' ] . ' ' . $data[ 'currency' ] ) . '"';
90 - $log_message .= "\t" . '"' . addslashes( serialize( $minfraud_hash )) . '"';
91 - $log_message .= "\t" . '"' . addslashes( serialize( $this->minfraud_response )) . '"';
 90+ $log_message .= "\t" . '"' . addslashes( json_encode( $minfraud_hash )) . '"';
 91+ $log_message .= "\t" . '"' . addslashes( json_encode( $this->minfraud_response )) . '"';
9292 $log_message .= "\t" . '"' . addslashes( $pfp_gateway_object->action ) . '"';
9393 $log_message .= "\t" . '"' . addslashes( $data[ 'referrer' ] ) . '"';
9494 $this->log( $data[ 'contribution_tracking_id' ], 'minFraud query', $log_message );

Status & tagging log