r71217 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71216‎ | r71217 | r71218 >
Date:23:03, 17 August 2010
Author:awjrichards
Status:deferred
Tags:
Comment:
Added 'referrer' to logging for initial minfraud queries and am running log strings through addslashes() for better parsability
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/minfraud.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/minfraud.php
@@ -84,11 +84,12 @@
8585
8686 // log the message if the user has specified a log file
8787 if ( $this->log_fh ) {
88 - $log_message = '"' . $data[ 'comment' ] . '"';
89 - $log_message .= "\t" . '"' . $data[ 'amount' ] . ' ' . $data[ 'currency' ] . '"';
90 - $log_message .= "\t" . '"' . serialize( $minfraud_hash ) . '"';
91 - $log_message .= "\t" . '"' . serialize( $this->minfraud_response ) . '"';
92 - $log_message .= "\t" . '"' . serialize( $pfp_gateway_object->action ) . '"';
 88+ $log_message = '"' . addslashes( $data[ 'comment' ] ) . '"';
 89+ $log_message .= "\t" . '"' . addslashes( $data[ 'amount' ] . ' ' . $data[ 'currency' ] ) . '"';
 90+ $log_message .= "\t" . '"' . addslashes( serialize( $minfraud_hash )) . '"';
 91+ $log_message .= "\t" . '"' . addslashes( serialize( $this->minfraud_response )) . '"';
 92+ $log_message .= "\t" . '"' . addslashes( $pfp_gateway_object->action ) . '"';
 93+ $log_message .= "\t" . '"' . addslashes( $data[ 'referrer' ] ) . '"';
9394 $this->log( $data[ 'contribution_tracking_id' ], 'minFraud query', $log_message );
9495 }
9596 return TRUE;

Status & tagging log