r71207 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71206‎ | r71207 | r71208 >
Date:18:44, 17 August 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
*(bug 24811) Link to the revision being followed up in a followup email
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -126,6 +126,8 @@
127127 'codereview-email-subj2' => '[$1] [$2]: Follow-up changes',
128128 'codereview-email-body2' => 'User "$1" made follow-up changes to $2.
129129
 130+Full URL for followed up revision: $5
 131+
130132 Full URL: $3
131133
132134 Commit summary:
Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -341,6 +341,9 @@
342342 $revision = CodeRevision::newFromRow( $row );
343343 $users = $revision->getCommentingUsers();
344344
 345+ $rowTitle = SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() . '/' . $row->mId );
 346+ $rowUrl = $rowTitle->getFullUrl();
 347+
345348 $revisionAuthor = $revision->getWikiUser();
346349
347350 //Add the followup revision author if they have not already been added as a commentor (they won't want dupe emails!)
@@ -360,7 +363,7 @@
361364 $lang = array( 'language' => $user->getOption( 'language' ) );
362365 $user->sendMail(
363366 wfMsgExt( 'codereview-email-subj2', $lang, $this->mRepo->getName(), $this->getIdString( $row->cr_id ) ),
364 - wfMsgExt( 'codereview-email-body2', $lang, $committer, $this->getIdStringUnique( $row->cr_id ), $url, $this->mMessage )
 367+ wfMsgExt( 'codereview-email-body2', $lang, $committer, $this->getIdStringUnique( $row->cr_id ), $url, $this->mMessage, $rowUrl )
365368 );
366369 }
367370 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r71208Add getFullUrl function as minor followup to r71207reedy18:47, 17 August 2010

Comments

#Comment by Reedy (talk | contribs)   18:44, 17 August 2010

Wording could probably do with some tweaking...

#Comment by Reedy (talk | contribs)   18:44, 17 August 2010

Wording could probably do with some tweaking...

Status & tagging log