r71200 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71199‎ | r71200 | r71201 >
Date:12:54, 17 August 2010
Author:werdna
Status:deferred (Comments)
Tags:
Comment:
Fix weird sorting for LQT namespaces on wikis without them installed
Modified paths:
  • /trunk/extensions/LiquidThreads/i18n/Lqt.namespaces.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/i18n/Lqt.namespaces.php
@@ -2,6 +2,14 @@
33
44 $namespaceNames = array();
55
 6+// For wikis without LiquidThreads installed.
 7+if ( ! defined('NS_LQT_THREAD') ) {
 8+ define( 'NS_LQT_THREAD', 90 );
 9+ define( 'NS_LQT_THREAD_TALK', 91 );
 10+ define( 'NS_LQT_SUMMARY', 92 );
 11+ define( 'NS_LQT_SUMMARY_TALK', 93 );
 12+}
 13+
614 $namespaceNames['en'] = array(
715 NS_LQT_THREAD => 'Thread',
816 NS_LQT_THREAD_TALK => 'Thread_talk',

Comments

#Comment by Nikerabbit (talk | contribs)   14:47, 17 August 2010

I don't think this works. This file is not loaded on every request, but only once before it's cached in localisation cache.

#Comment by Werdna (talk | contribs)   16:25, 17 August 2010

It does work. Remember that the constants are expanded when the file is loaded…

#Comment by Nikerabbit (talk | contribs)   20:29, 17 August 2010

Riight, this is for WMF.

Status & tagging log